Clarified Slices documentation #1366
Conversation
|
Thanks for your contribution! 🙏 Sorry that this PR has been overlooked for so long... 🙈 Could you please sign-off your commit according to the DCO, cf. Contributing guideline? |
|
Hey @hankem, yeah, sure, I've signed off the commit |
archunit/src/main/java/com/tngtech/archunit/library/dependencies/Slice.java
Outdated
Show resolved
Hide resolved
|
@hankem done :) |
|
Oh, and one more request (sorry! 🙈): Could you please rebase your branch onto the current |
|
oops, sorry, I'll reopen it :) CC: @hankem done, rebased |
archunit/src/main/java/com/tngtech/archunit/library/dependencies/Slice.java
Outdated
Show resolved
Hide resolved
|
I applied the suggestion, and the commit is signed off, it is strange that the DCO is red... |
hankem
dismissed
codecholeric’s stale review
Requested changes have been applied. I'll try to get this merged.
|
@mipo256, could you allow edits from maintainers (or rebase to GitHub doesn't let me merge this PR because |
The slices documentation does not mention a very important aspect, that is that, technically, Slices do not represent a given set of packages, although the example shows that. Signed-off-by: mipo256 <mikhailpolivakha@gmail.com>
|
Rebased @hankem |
The slices documentation does not mention a very important aspect, that is that, technically, Slices do not represent a given set of packages, although the example shows that.